search

Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.53k stars 3.41k forks source link

Sticky Header #1629

Open jericmontana opened 2 years ago

jericmontana commented 2 years ago

Describe the current behavior sticky header does not work properly when scrolling while the drop-down menu is open

Describe the expected behavior when scroll up while drop-down menu is open, drop-down menu should be close and the header should be sticky

Version information (Dawn, browsers and operating systems)

Possible solution

change the HTML tag:

--> and also the script: class StickyHeader extends HTMLElement { ... closeMenuDisclosure() { this.disclosures = this.disclosures || this.header.querySelectorAll('details-disclosure'); this.disclosures.forEach(disclosure => disclosure.close()); } ... } **Additional context/screenshots** Add any other context about the problem here. If applicable, add screenshots to help explain.
kimberlyoleiro commented 1 year ago

Thanks for your input. Please retest on Dawn v7.0.1 and confirm issue persists by Dec 16th, 2022.

stpangia commented 1 year ago

I can confirm it still happens in 7.0.1