Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.56k stars 3.46k forks source link

Connect social links theme settings to brand settings social links #1747

Open nicklepine opened 2 years ago

nicklepine commented 2 years ago

With social links now being fields in the brand settings section of the admin, we can remove the social link settings from themes.

When a merchant sets values on the social link fields in brand settings, those will be then be surfaced directly on the theme.

image

bacounts commented 2 years ago

@nicklepine - I do think we should create issues like this for each aspect of the Brand Settings (ie., logo, all colors, ect as the theme's default when present). For example if a user is not as familiar with the editor's dynamic source icon, hooking up the brand logo is not as apparent.

A secondary thought, should Admin > Online Store > Preference > Social sharing image be moved to the brand section near the social links?

kimberlyoleiro commented 1 year ago

We're receiving some feedback that merchants are copying & pasting the suggested/helper text social accounts in theme settings ie facebook.com/shopify, which is driving buyers to Shopify's social accounts.

Root Problem: Merchants are misinterpreting how to set up their social media accounts on themes

Potential solutions

  1. Change the helper text to something more generic facebook.com/your-account-handle
  2. Completely remove/ replace theme settings > social section with brand settings
  3. Automatically connect theme setting > social section > dynamically to brand settings

Questions to build confidence

  1. Are brand settings widely adopted?
  2. What would be implications for merchants who already have socials connected via theme settings

This issue is being tracked here https://github.com/Shopify/dawn/issues/2722#issuecomment-1602649174

kimberlyoleiro commented 1 year ago

Connecting to brand settings is not something that will be prioritized at the moment. The recent issue of buyers navigating to Shopify socials is being tracked here https://github.com/Shopify/dawn/issues/2722#issuecomment-1602649174