Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.48k stars 3.32k forks source link

Quick order list: quantity that doesn't not respect quantity limit can be added to cart #2857

Open nicklepine opened 1 year ago

nicklepine commented 1 year ago

Meli's video: https://screenshot.click/17-43-5mgav-rzrde.mp4

Slack thread: https://shopify.slack.com/archives/C04NPNBGU87/p1689619584764189

There are 2 bugs - probably related:

  1. Hitting enter after inputing quantity on quick order list on a product that has 1 or zero variants redirects to /cart
  2. I am able to add submit quantity that does not respect quantity limits (bug video)

I think the fix should include::

Video recap: https://screenshot.click/17-29-afrh6-clay1.mp4

lucianosousa commented 1 year ago

I am working with the cart team in this ticket. My PR opened the discussion about how this could be fixed and cart team is taking from there.

Most likely, the fix will come from this PR I will keep eyes close to it

thagxt commented 1 year ago

Hey, @lucianosousa While you are working on that can you also look at this issue: #2994 it is affecting all themes not just Dawn.

lucianosousa commented 12 months ago

@thagxt can you take a look at this spin instance

I think I solved it too