Open KaichenWang opened 1 year ago
Given this is off by default, I'll move it to the backlog
@danielvan what's the expected behaviour for the language/currency picker sizing across
We tried to match the text size of the announcement bar but now there seem to be some inconsistencies, and or it's too big in some cases
@kimberlyoleiro @danielvan I suggest we use the body font (instead of heading) and the text size used in the header for that currency and language selector. This way the selector size will feel consistent with the menu links in the header and shouldn't scale as intensely if the merchant wants to increase their heading font size. The footer selectors should remain the same.
Amazing! Thank you @Oliviammarcello
Just to double check: we are using the body font across all elements in the announcement bar (currency, country, announcements) and we are following the body font scaling.
If this is it, I'm onboard. The visual change is minimal for merchants that upgrade, and the consistency is worth it.
@danielvan Right now we use the heading font across all text in the announcement bar. I was suggesting just updating the currency and country selectors to the body font and keeping the actual announcements in the heading font, since that would be a more minimal visual change for merchants.
However, I am in favour of changing the announcements to body as well since it would reduce the overall height of the bar and be more readable when a more expressive header typeface is used with a small type size. Example
Depending on typography choice and scaling, the currency/language selectors in the announcement bar can be large because it's inheriting heading font-size