search

Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.48k stars 3.33k forks source link

Rating stars not showing up #2936

Open shayanabbas opened 1 year ago

shayanabbas commented 1 year ago

Describe the current behavior

Rating stars not showing up on Product single, collection or featured product section

Describe the expected behavior

It should show the stars, which are not showing because pointing to wrong variable for values

Version information (Dawn, browsers and operating systems)

Possible solution

Need to fix correct variable names here:

change product.metafields.reviews.rating.value.rating => product.metafields.reviews.rating.value
change card_product.metafields.reviews.rating.value.scale_max => card_product.metafields.reviews.rating.scale_max

https://github.com/Shopify/dawn/blob/main/snippets/card-product.liquid#L169-L190 https://github.com/Shopify/dawn/blob/main/sections/main-product.liquid#L431-L452 https://github.com/Shopify/dawn/blob/main/sections/featured-product.liquid#L479-L500

shayanabbas commented 1 year ago

PR #2937