Theme Check passes in CI but not locally with `shopify theme check`

[st3phhays]

Describe the current behavior

It appears, as of this commit, that the Theme Check is passing on CI. However, when running shopify theme check locally on a fresh repo cloned from the same commit, shopify theme check reports 291 files inspected, 29 offenses detected, 20 offenses auto-correctable

Describe the expected behavior

If the Theme Check passes in CI, it should also pass locally given that the repos are exactly at the same point in time.

Version information (Dawn, browsers and operating systems)

• Dawn Version: 11.0.0, from commit https://github.com/Shopify/dawn/commit/7d02769927d723f74166885690d9d0ee53266401
• Chrome Version 114.0.5735.198
• macOS Version 12.5.1

Possible solution

I'm unsure of how to fix this.

Additional context/screenshots

[renzonj]

same issue 🤔..

[Alonski]

Would a PR fixing this be welcome? CC @eugenekasimov as it seems this is happening since your commit (maybe by luck)

[Alonski]

I think I found the problem. It seems that shopify theme check doesn't exit with an exit code of 1 but instead 0 which makes CI believe it passed. The issues that can be fixed locally are mentioned in the CI report: https://github.com/Shopify/dawn/actions/runs/6814109231/job/18530227027

These all seem to be suggestions thought so maybe that is why this doesn't error.

Would it make sense for suggestions to actually error the action so that this theme remains without theme check issues even if they are suggestions?

The action is defined here: https://github.com/Shopify/theme-check-action/blob/main/entrypoint.sh

[eugenekasimov]

@Alonski it's always welcome to PRs in dawn public. I can't guarantee how quick we can have bandwidth for reviewing it though. But if it's something simple and you can open a quick PR for this, please go ahead 👍

[abhishekjani08]

I would like to work on this issue!✅🚀