search

Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.49k stars 3.35k forks source link

Shopify CDN won't minify Dawn's javascript files #3007

Open sciascia opened 1 year ago

sciascia commented 1 year ago

Couldn't see an issue for this and not sure why (others have noted this on the user forums) so sorry if this is because of something else, but it appears that Shopify's CDN no longer minifies Dawn's JS?

Describe the current behavior

Since August sometime, the Shopify CDN which is supposed auto-minify all theme JS won't minify Dawn's JS files.

Describe the expected behavior

Shopify CDN is supposed to auto-minify all theme JS files as per: https://shopify.dev/changelog/shopify-now-serves-minified-javascript-files-automatically

Version information (Dawn, browsers and operating systems)

Possible solution

Make the Shopify CDN support newer javascript like es5 or es6? Not sure if this is the issue or not.

Additional context/screenshots

I see almost 1000 warnings in SEMRush about unminified JS files which is how I came across the issue. Others on the forums have also noticed the issue: https://community.shopify.com/c/technical-q-a/cdn-files-are-not-minified/m-p/2081940

And here are some example files showing minification errors from our live site which is using Dawn.

https://www.thehotelsheet.co.nz/cdn/shop/t/25/assets/animations.js?v=88693664871331136111692931065

https://www.thehotelsheet.co.nz/cdn/shop/t/25/assets/details-modal.js?v=25581673532751508451692931067

https://www.thehotelsheet.co.nz/cdn/shop/t/25/assets/search-form.js?v=133129549252120666541692931067

image

mattvague commented 1 year ago

This seems to be happening on all the top themes

meewgumi commented 1 year ago

Yeah this appears to be a Shopify CDN bug. I sent in a ticket but still waiting for a response—others should also send a bug report via the Shopify Partners Support area, so that it gets flagged to their product team.

Also, does anyone have a link to a working Github Action for auto minification? Or suggestions for automated workarounds while we wait for a platform bugfix?

wmurphy commented 1 year ago

We are observing the same issue. Will report to Shopify support to see if they can escalate as it seems related to the platform and not the theme.

ahmedu007 commented 8 months ago

Is this definitely a CDN bug? My question is why are they trying to even target es5? What's wrong with es6?