Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.53k stars 3.4k forks source link

Section headings need selectable heading tags for SEO #3046

Open sciascia opened 1 year ago

sciascia commented 1 year ago

Describe the current behavior

There is no way to set the correct heading level in any of Dawn's built-in blocks that use non-rte headline fields.

Describe the expected behavior

The user should be able to choose the correct heading tag (H1, H2, H3 etc) depending on a block's position within the page.

Block headings can appear as the first heading (so should be set to H1) or as just another heading within a page (e.g H3). So depending on the block and the page, pages can end-up without H1 tags.

This creates a bunch of annoying SEO issues without an easy way for the user to correct - especially when we spend our lives teaching clients the importance of proper mark-up.

Version information (Dawn, browsers and operating systems)

Possible solution

All non-rte headline fields require a way for the user to set the correct heading tag (depending on a block's position within a page).

Additional context/screenshots

Related to issues #1245 #682

lissa2882 commented 10 months ago

This is a screenshot of the code changes we made to resolve this issue; it would be great if this could be added to all sections. Screenshot 2023-12-21 at 3 36 34 PM