Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.52k stars 3.4k forks source link

Mobile scrolling behavior of certain sections #3055

Open andrewetchen opened 1 year ago

andrewetchen commented 1 year ago

Describe the current behavior

On mobile, when viewing a storefront that contains a section with the "Enable swipe on mobile" section setting (e.g., featured collection), a user may encounter an issue when attempting to scroll further down the page.

This only occurs with "Reveal sections on scroll" enabled.

Replication Steps

  1. Add a featured collection on the homepage.
  2. Enable the "Enable swipe on mobile" section setting.
  3. Enable Theme settings > Animations > Reveal sections on scroll.
  4. View store on mobile and vertically scroll past the product cards.

Additional context/screenshots

Merchant bug tracker:

https://github.com/Shopify/dawn/assets/28404165/9d52229f-395b-4554-a507-1ab6011102d8

andrewetchen commented 1 year ago

I followed the replication steps and couldn't reproduce the problem. The only instance where I encountered an inability to scroll vertically was when I was actively scrolling horizontally through the product card and hadn't yet released my touch from the screen within the featured collection (which is expected).

Tested using Dawn 11.0.0 and the latest main. I also tested the following browsers on iOS 17.0.3 (iPhone 14 Pro Max):

There could be other edge cases so let's keep this ticket open for further investigation and testing.