Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.55k stars 3.45k forks source link

Add Tags to the Storefront filtering #333

Open appscompany opened 3 years ago

appscompany commented 3 years ago

Describe the enhancement you'd like Adding tags to the storefront filtering in addition to the type,vendor,price and variant options. I think this is required by majority of merchants

Regards Muthu

JackB47 commented 3 years ago

+1 for this 👍

JamieBradders commented 3 years ago

Agreed! I often need something like this for themes. Although I think this is a Shopify feature rather than something specific to Dawn? Can anyone recommend an alternative solution for tags? Is the Storefront API the best approach?

sja87 commented 3 years ago

I also need a solution for tag or metafiled filtering. At the moment this is the only reason why we cannot switch to the new dawn theme.

bredowmax commented 3 years ago

Need it as well

patrickbjohnson commented 3 years ago

+1

oksushi commented 3 years ago

See further discussion here: https://github.com/Shopify/storefront-api-feedback/discussions/10

JamieBradders commented 3 years ago

It still looks like tags have been disregarded in the initial proposal, but plenty of people are asking for the support in the discussion which is encouraging.

We ended up using a paid plugin called Boost Commerce. The plugin generates HTML for the filter trees and product cards whilst giving vendors the ability to configure these in the plugin settings. We couldn't get away with the default themes from Boost and I was pleased to find that Boost gives you the ability to modify the generated HTML. However, I found it quite a cumbersome task.

In the end I used their API to build up a JS based filtering solution and it was much easier (for me at least) this also poses a good solution for headless storefronts.

Website - https://boostcommerce.net/ API Docs - https://help.boostcommerce.net/article/458-filter-search-api

Given the amount of time it would take to develop an equivalent solution, I think the cost of the plugin was worth my while. At least until tag support is available Shopify's core filtering.

alinad-am commented 3 years ago

+1

ghost commented 3 years ago

+1

MasjZam commented 2 years ago

Although not tag support, the Online Store does now support filtering by metafields as documented here.

This allows you to include custom filters beyond what is already included in a product's variant options. This gives you a more structured solution with type and value validation that isn't possible with tags.

mkromann commented 2 years ago

Although not tag support, the Online Store does now support filtering by metafields as documented here.

This allows you to include custom filters beyond what is already included in a product's variant options. This gives you a more structured solution with type and value validation that isn't possible with tags.

Hi @MasjZam

That is fantastic — a much better solution in my opinion. Unfortunately, there are some issues that make it unusable for many stores.

Comma-separated list I tested it out the other day, and couldn't get a comma-separated list to work as an input. It is documented as a feature here: https://shopify.dev/themes/navigation-search/filtering#:~:text=Metafield,or%20canada%2Cusa.

It has also been reported here: #381.

There are many cases where you need to include a product/variant in multiple groups.

1000 products limit What is up with the 1000 products limit? This is another case where you either cannot use storefront filtering, OR you are too scared to commit, as you might outgrow the feature (this is the case for us). I understand that this is an API thing and not related to Dawn specifically but it has been reported here: #89 — but it has also been asked about numerous times here: https://github.com/Shopify/storefront-api-feedback/discussions/10.

This limit is especially peculiar, as big collections are the ones that require filtering the most. Why is this limit in place? And is it something that you are looking to increase? Or is this how it is gonna for the foreseeable future?

——

I really appreciate these improvements and hope they can be further improved :)