Feature product section not loading product metafield correctly

Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.

Other

2.53k stars 3.42k forks source link

Feature product section not loading product metafield correctly #3433

Open mkoenig-shopify opened 6 months ago

mkoenig-shopify commented 6 months ago

Describe the current behavior

When using dynamic sources with Dawn "featured product" section, when you choose a static product source for the section, you're able to choose between the different variants without issue but when you choose a product as a dynamic source, all of the variants show as out of stock. They specifically noticed this when trying to dynamically display different featured products, depending on the blog post being viewed. I was personally able to replicate this myself on my test store and have a page that shows the issue we're seeing: Video recording of the issue on my test store: https://screenshot.click/18-53-020vd-2y8nh.mp4 Page on my test store (password: testpass): https://thomas-test-store-1234.myshopify.com/blogs/news/unleashing-your-inner-cowboy-conquering-bugs-on-shopify

Describe the expected behavior

The proper variant should be shown with all applicable and up to date data.

Version information (Dawn, browsers and operating systems)

Dawn Version: 7.0.1
Chrome Version 108.0.5359.124
macOS Version 13.1

Possible solution

Additional context/screenshots

ludoboludo commented 6 months ago

From what I'm seeing the fetch request seem fine but what we get back from the API isn't seeing the product set via the metafields, not the metafield definition themselves. Here is what I was thinking when taking a quick look: video

eunicelyt commented 6 months ago

Hi team! any updates on this?

ludoboludo commented 6 months ago

No update on this at the moment @eunicelyt 🙁

ludoboludo commented 3 months ago

Curious to know/check if this is still happening on the latest version of the theme. Nothing was done specifically for this issue but when I tried to replicate the issue like I did in the video shared above, it didn't seem to happen. Though my setup is: a feat. product linked to a dynamic source (which is the product from the template I'm on) on the product page. In my video, I see that the buy buttons are showing sold out but it didn't happen when I tried again now 🤔

eunicelyt commented 3 months ago

Hello! thank you for checking in on this, seems like it is still happening on the latest Dawn version 15.0.0 when I check on my test store:

test store Internal
theme editor link
video recording on what I observe on my end - all variants are in stock, in the new version it just simply marks it as unavailable without any price, when the variant is in stock 🥹

aleightizer commented 4 days ago

Hi folks,

We have another report of this and I've been testing it out.

During my replication on Dawn, Spotlight, Refresh, Sense and Craft.

You can add the first variant to cart without issue
Trying to select a different variant causes the variant selector to disappear and for the product to appear as sold out until the page is reloaded.

When tested on Impact version 4.2.0

The variant selector stayed in place
Regardless of the variant selected, only the first variant was added to the cart.
Product does not show as sold out.

Here is my video replication: https://screenshot.click/09-17-ar75e-kitgw.mp4

Is there any more recent Github issues or documentation than https://docs.google.com/spreadsheets/d/1qgriv1OdbnsyVViPFaQM9Vlc8RJpjAfdUvHuCbreFfU/edit?gid=171768085#gid=171768085 or https://docs.google.com/document/d/1tM1Tb-cVh2SyDrt5HpD9A63OBMnNflgGfp6txxBH5Qk/edit?tab=t.0#heading=h.59bt135p75j0 to follow more recent work?