In some instances of the slideshow, there can be some odd behaviours happening with some scrolling on the media when it shouldn't.
This is to prevent this behaviour.
To replicate the issue you would need to use an image that's pretty tall, then set the slideshow section size to Adapt to first image. Check on mobile and you could get stuck on the image itself moving just a little bit: video
Prevent vertical overflow.
That wouldn't have worked on sliders as they can have shadow and borders but the slideshow doesn't so I believe it should be safe.
PR Summary:
In some instances of the slideshow, there can be some odd behaviours happening with some scrolling on the media when it shouldn't. This is to prevent this behaviour.
To replicate the issue you would need to use an image that's pretty tall, then set the slideshow section size to
Adapt to first image
. Check on mobile and you could get stuck on the image itself moving just a little bit: videoWhy are these changes introduced?
Fixes https://github.com/Shopify/dawn/issues/3454
What approach did you take?
Prevent vertical overflow. That wouldn't have worked on sliders as they can have shadow and borders but the slideshow doesn't so I believe it should be safe.
Visual impact on existing themes
Should fix a mobile issue.
Testing steps/scenarios
Demo links
Checklist