Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.36k stars 3.13k forks source link

[Slideshow] prevent vertical overflow on slideshow #3455

Closed ludoboludo closed 3 weeks ago

ludoboludo commented 4 weeks ago

PR Summary:

In some instances of the slideshow, there can be some odd behaviours happening with some scrolling on the media when it shouldn't. This is to prevent this behaviour.

To replicate the issue you would need to use an image that's pretty tall, then set the slideshow section size to Adapt to first image. Check on mobile and you could get stuck on the image itself moving just a little bit: video

Why are these changes introduced?

Fixes https://github.com/Shopify/dawn/issues/3454

What approach did you take?

Prevent vertical overflow. That wouldn't have worked on sliders as they can have shadow and borders but the slideshow doesn't so I believe it should be safe.

Visual impact on existing themes

Should fix a mobile issue.

Testing steps/scenarios

Demo links

Checklist

ludoboludo commented 3 weeks ago

Havent been able to reproduce 🤔 Am I missing a step?

https://screenshot.click/08-07-oaj8l-uh8vo.mp4

A couple things to try and replicate @sofiamatulis :