Closed lgunn4 closed 2 weeks ago
Couple things we might need to check:
translation-platform
check failed, and says to reach out to a Slack channel for assistance because you're renaming locale files. Please do this :D otherwise we might have some problems with our next translations PR.The translation-platform check failed, and says to reach out to a Slack channel for assistance because you're renaming locale files. Please do this :D otherwise we might have some problems with our next translations PR.
The PR is good to go from a Translation Platform perspective, and I cleared the failing check! 👍🏻
PR Summary:
Renamed regional locale keys to their default counterpart (e.g.
ro-RO
toro
).Currently if a merchant adds a locale with a regional variant (
ro-RO
) as an alternate locale (ro
), the default translations that we support out of the box does not include this locale code (we supportro
notro-RO
... which is wrong)In order to address this we are updating the root locale keys of the regional locales to their default variations.
Why are these changes introduced?
Work towards this issue: https://github.com/Shopify/store-localization/issues/4214
What approach did you take?
Renamed translation files and updated translation.yml
Other considerations
Will this impact the upgrade path for merchants ?
Visual impact on existing themes
N/A Merchants using these locale codes as an alternate locale will now be able to see a translated storefront (out of the box translations)
Testing steps/scenarios
Demo links
Store: https://logan-development-test.myshopify.com/ Password: passwordpassword
Checklist