Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.54k stars 3.44k forks source link

email-signup-banner.liquid: "templates" should be updated to "enabled_on" #3622

Open jbrrrrr-abds opened 1 month ago

jbrrrrr-abds commented 1 month ago

Describe the current behavior

Shopify CLI 'theme check' fails with 1 error when using the latest Dawn theme update.

Error:

─ info ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                                                                      │
│  sections/email-signup-banner.liquid                                                                                                 │
│                                                                                                                                      │
│                                                                                                                                      │
│  [error]: ValidSchema                                                                                                                │
│  Property templates is not allowed.                                                                                                  │
│                                                                                                                                      │
│  402  "templates": ["password"]

Describe the expected behavior

Shopify CLI 'theme check' should pass with no errors.

Version information (Dawn, browsers and operating systems)

Possible solution

The error is related to line 402 of sections/email-signup-banner.liquid. According to the section schema docs, using "templates" as a property is deprecated in favor of "enabled_on" and "disabled_on".