Hotfix/remove-left-and-right-whitespace - Githubissues

Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.

Other

2.54k stars 3.45k forks source link

Hotfix/remove-left-and-right-whitespace #3625

Open nikitasol opened 2 months ago

nikitasol commented 2 months ago

PR Summary:

Removes left and right whitespaces inside title meta tag

Why are these changes introduced?

Cleaning whitespace

What approach did you take?

add hyphens -> {{- page_title -}}

Visual impact on existing themes

No visual impact

Checklist

[ x ] Added PR summary for release notes
[ ] Requested review from UX (Only for changes that are affecting the experience or perceivable visual details)
[ ] Created a ticket for the help.shopify.com documentation team about updates to theme settings. (Internal-only task)
[ x ] Followed theme code principles
[ x ] Linted with Theme Check
[ x ] Tested on mobile
[ x ] Tested on multiple browsers
[ x ] Tested for accessibility