search

Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.54k stars 3.44k forks source link

`count` not being used in pluralised translations #3655

Open david-w-shopify opened 4 weeks ago

david-w-shopify commented 4 weeks ago 
{
  "sections": {
    "quick_order_list": {
      "items_added": {
        "one": "{{ quantity }} item added",
        "other": "{{ quantity }} items added"
      },
      "items_removed": {
        "one": "{{ quantity }} item removed",
        "other": "{{ quantity }} items removed"
      }
    }
  }

I'm not sure if these translations should actually be deleted because in the copy of Dawn that I have, the translation doesn't appear to actually be used anywhere. I haven't had time to check the latest version yet.

If it has been left in intentionally though, I believe quantity should be replaced with count in order for the translation pluralisation rules to kick in. Otherwise I need to pass both quantity and count values.