search

Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.54k stars 3.45k forks source link

[Slideshow] Fixing an issue with block attributes #3663

Open alexandcote opened 2 weeks ago

alexandcote commented 2 weeks ago

PR Summary:

  1. The attributes were rendered multiple times per block

Why are these changes introduced?

Improving the Theme Editor experience.

Testing steps/scenarios

  1. Open the theme editor
  2. Add the slideshow section
  3. Hover the block in the sidebar, be sure the power preview outlines the block properly.

Checklist

ludoboludo commented 2 weeks ago

cc: @Roi-Arthur could we get your review on this too :)