Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.46k stars 3.3k forks source link

Filtering does not take effect when a collection has a tag in its URL #653

Open MegsParkinson opened 2 years ago

MegsParkinson commented 2 years ago

Describe the current behavior

When a menu item is a collection with a product tag as a filter, the filter function does not filter the products. image

[Screenshot removed]

Describe the expected behavior

The filter should filter the products in the collection, even though they have been already filtered by product tag in the navigation menu.

Version information (Dawn, browsers and operating systems)

Possible solution None found

Additional context/screenshots Was reported previously, issue has been closed but not resolved: #129

tairli commented 2 years ago

I guess, #129 was closed because it's not a theme but backend problem.

TGIFelix commented 2 years ago

Having the same issue. Did anyone find a fix?

rcobiella commented 2 years ago

Same here. Any workarounds?

MegsParkinson commented 2 years ago

You can create automated collections using the product tags and use those new collections in the menu. This works, so for now I'm using that as a workaround.

salvodees commented 2 years ago

Hi @MegsParkinson, I have been investigating this issue and our devs confirmed the issue you are reporting is not exactly the same as this one: #129.

Tag filtering is considered more of a hack and not a scalable/dynamic design choice like the new filtering system is, therefore not seeing the filters on a collection page where a tag has been used as a filter is an expected behaviour and the result of an explicit product decision.

In other words, a merchant can use tags for filtering OR use filters for filtering. They can not be used together.

This has also been documented on this Shopify Doc.

image

On the other hand, what wasn't expected is that the filters showed up in the theme with a tag applied. They should not have been showing up. That's what was fixed in this issue.

I hope this clarifies and if there are no further questions please feel free to close this issue.

robotshatemonkeys commented 2 years ago

This has SEO implications, that make migration complicated. Imagine you have one of the following clusters structure ( faceted search ) /collections/brandname/brandtype /collections/gender/brand

It will be really hard to migrate to the new filtering:

I really don't understand why Shopify doesn't allow both solutions to work together. Faceted search and Filtered search are complementary features. There are many giant retails applying mixed solutions, including zalando, farfetch and many others, and it's for a reason.
Some filters make sense as crawlable faceted subfolders while others as url queries.

This sounds more like a backend technical issue than a design / business decision.