search

Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.53k stars 3.41k forks source link

[Social Icons] TikTok Icon does not scale with other icons when width and height are changed #940

Open stephendawsondev opened 2 years ago

stephendawsondev commented 2 years ago

Describe the current behavior When the width and height are changed on the social media icons (through code), the TikTok icon doesn't scale with the others

Describe the expected behavior It should match the size of the other icons when the icon selector is changed

Version information (Dawn, browsers and operating systems)

Possible solution Add a viewbox to the SVG, like the Facebook icons's viewbox viewBox="0 0 18 18"

Additional context/screenshots

ludoboludo commented 2 years ago

Thanks for bringing this up to our attention @stephendawsondev! 👍

I think we could also remove the width and height attributes on there. I will add it to the list to be triaged so priority can be set on the issue.