search

Shopify / deprecation_toolkit

⚒Eliminate deprecations from your codebase ⚒
MIT License
454 stars 40 forks source link

Fix rubocop in main #100

Closed IvanTakarlikov-st closed 5 months ago

IvanTakarlikov-st commented 5 months ago

Ignores rubocop offense after merging https://github.com/Shopify/deprecation_toolkit/commit/1d4c6e4f16ef3e036b6b500be3eb175d52536530

IvanTakarlikov-st commented 5 months ago

@casperisfine can we merge it to fix build in main branch and make a release maybe?

IvanTakarlikov-st commented 5 months ago

@casperisfine any particular reason to not support activesupport older than 7?

casperisfine commented 5 months ago

Fixed in https://github.com/Shopify/deprecation_toolkit/commit/eed3078480cf498ecaad32ed2a4bc35adf6fae10

casperisfine commented 5 months ago

any particular reason to not support activesupport older than 7?

Mostly to not have a giant test matrix. 6.1 is quite old, but it's true it's not strictly EOL. I suppose I can add it back.

casperisfine commented 5 months ago

2.2.0 released.