search

Shopify / deprecation_toolkit

⚒Eliminate deprecations from your codebase ⚒
MIT License
460 stars 40 forks source link

Test against different ActiveSupport versions on Travis #13

Closed XrXr closed 5 years ago

XrXr commented 5 years ago

I used Appraisals to generate the Gemfiles. This is an extra development dependency but I think it's worth it for the added convenience.

Closes #13

rafaelfranca commented 5 years ago

This is an extra development dependency but I think it's worth it for the added convenience.

I prefer not to. It is easy to support multiple gemfiles without Appraisals. You can keep the Gemfiles generated by the tool and use BUNDLE_GEMFILE environment variable to test against it.

Edouard-chin commented 5 years ago

Looks like tests are failing because we use Bundler.root in the project https://github.com/Shopify/deprecation_toolkit/blob/9237c8b9f53bc7e15faed8a31ccd02667d8e4c4d/lib/deprecation_toolkit/read_write_helper.rb#L47 (deprecations gets read/written at the root of the project). Since we have gemfile inside a gemfiles subdirectory it now breaks. We'd have to find a workaround for that.

XrXr commented 5 years ago

@Edouard-chin what do you think about putting the gemfiles under the root of the repo?

Edouard-chin commented 5 years ago

The best would have been to get the root of the project without relying on Bundler but I have tried and it's non trivial.

I'd prefer if we leave the gemfiles inside a gemfiles folder and create the same deprecations directory with a symlink to the actual deprecations files. It make things more explicit