search

Shopify / deprecation_toolkit

⚒Eliminate deprecations from your codebase ⚒
MIT License
460 stars 40 forks source link

Add support for activesupport 4.2 #15

Closed andrewmarkle closed 5 years ago

andrewmarkle commented 5 years ago

This adds support for ActiveSupport > 4.2 and closes #14

Let me know if I missed anything!

andrewmarkle commented 5 years ago

Thanks for the review @Edouard-chin!

Edouard-chin commented 5 years ago

Can you squash your commits and I'll merge :)

On Sat, Sep 29, 2018, 12:44 PM Andrew Markle notifications@github.com wrote:

Thanks for the review @Edouard-chin https://github.com/Edouard-chin!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Shopify/deprecation_toolkit/pull/15#issuecomment-425658675, or mute the thread https://github.com/notifications/unsubscribe-auth/AHvvhiPePp6BX3BAZ1iZlqqIph3aUGZTks5uf6NqgaJpZM4W5M2z .

Edouard-chin commented 5 years ago

Thanks!

Edouard-chin commented 5 years ago

I have released version 1.0.2 which will contain the support to AS 4.2 you added

andrewmarkle commented 5 years ago

Thank you!