are defined inside the Minitest module. However, the methods themselves are independent. It seems safer to define them inside the DeprecationToolkit namespace, to keep this gem isolated from potential conflicts with other gems that could redefine Minitest#add_notify_behavior and Minitest#attach_subscriber.
These two methods: https://github.com/Shopify/deprecation_toolkit/blob/51692599f76f6b8748ea0868a271b271595c88e1/lib/minitest/deprecation_toolkit_plugin.rb#L23-L36
are defined inside the Minitest module. However, the methods themselves are independent. It seems safer to define them inside the
DeprecationToolkit
namespace, to keep this gem isolated from potential conflicts with other gems that could redefineMinitest#add_notify_behavior
andMinitest#attach_subscriber
.If you agree, I'd be happy to open a PR.