Shopify / deprecation_toolkit

⚒Eliminate deprecations from your codebase ⚒
MIT License
460 stars 40 forks source link

Fixes Kernel.warn not triggering deprecation #22

Closed Edouard-chin closed 5 years ago

Edouard-chin commented 5 years ago

Fixes #19

rmacklin commented 5 years ago

With this patch the original Kernel#warn is no longer aliased to Kernel#__original_warn. Was that intentional?

Edouard-chin commented 5 years ago

Yes the Kernel#__original_warn was to be able to call the original method. We don't need to call it anymore, we do it at the class level now