search

Shopify / deprecation_toolkit

⚒Eliminate deprecations from your codebase ⚒
MIT License
454 stars 40 forks source link

Only run Rubocop once in CI #73

Closed sambostock closed 1 year ago

sambostock commented 1 year ago

We can rely on TargetRubyVersion to check the compatibility across Ruby versions. Rubocop isn't a runtime dependency, so we don't need to re-run the Rubocop check across Ruby and Active Support versions.

Spin off from #72

sambostock commented 1 year ago

Not sure why Actions aren't triggering... 🤔

sambostock commented 1 year ago

As @etiennebarrie pointed out, I had a rogue strategy: in the workflow left over from the copy paste. Looks like it works now.