search

Shopify / deprecation_toolkit

⚒Eliminate deprecations from your codebase ⚒
MIT License
454 stars 40 forks source link

Support Rails.application.deprecators #74

Closed gmcgibbon closed 1 year ago

gmcgibbon commented 1 year ago

Add support for detecting deprecations raised with Rails.application.deprecators added in https://github.com/rails/rails/commit/7a26f2625533a0d45c0a1efbd264d3eb7462ee7b.

~One last part I'm still trying to figure out is how the deprecation tooling silences deprecations when recording. I don't understand why, but that doesn't seem to happen when recording deprecations from specific deprecators.~

ActiveSupport::Deprecaton.behavior defaults to :log and ActiveSupport::Deprecation.new.behavior defaults to :stderr (which is the problem) so I'll fix that separately.

adrianna-chang-shopify commented 1 year ago

Thanks for tackling this, Gannon! ❤️