Remove deprecations about ActiveSupport::Deprecation

Shopify / deprecation_toolkit

⚒Eliminate deprecations from your codebase ⚒

MIT License

467 stars 40 forks source link

Remove deprecations about ActiveSupport::Deprecation #90

Closed etiennebarrie closed 10 months ago

etiennebarrie commented 10 months ago

Fixes #88

A few random commits at first to clean things up. Then removed the deprecated calls in each test/spec file. Finally, to prevent a deprecation from the plugin being triggered on the project itself when running the tests, I defined the Rails module in test/test_helper.rb in a way that's more similar to 7.1.

We're still testing the other code path that's calling the deprecated API, but only when running tests with Active Support < 7.1.

gstokkink commented 10 months ago

@etiennebarrie thanks for fixing this! Can we get a new release for this (and maybe other fixes)?