I also had to bring the new "fake Rails 7.1 app" setup so that we wouldn't call the deprecated behavior. And similarly kept the tests testing that behavior but only when not running Active Support >= 7.1.
We paired with @adrianna-chang-shopify on this. We had to extract the RSpec plugin setup so that we could call it and check its behavior, previously the plugin specs were not exercising anything, just asserting that the behavior had happened while booting the spec suite.
Also CI was mistakenly configured where it was testing 7.1 with gemfiles/activesupport_7.0.gemfile Gemfile. And we were not testing with Gemfile directly.
I forgot a few in #90, this removes them.
I also had to bring the new "fake Rails 7.1 app" setup so that we wouldn't call the deprecated behavior. And similarly kept the tests testing that behavior but only when not running Active Support >= 7.1.
We paired with @adrianna-chang-shopify on this. We had to extract the RSpec plugin setup so that we could call it and check its behavior, previously the plugin specs were not exercising anything, just asserting that the behavior had happened while booting the spec suite.
Also CI was mistakenly configured where it was testing 7.1 with
gemfiles/activesupport_7.0.gemfileGemfile. And we were not testing withGemfiledirectly.