search

Shopify / deprecation_toolkit

⚒Eliminate deprecations from your codebase ⚒
MIT License
467 stars 40 forks source link

Allow configuration of minitest file paths and file names #95

Closed stephsachrajda closed 8 months ago

stephsachrajda commented 9 months ago

Background

Currently, deprecation toolkit uses class.name.underscore to name the files where it stores the deprecations, which works well in most cases, but means that in the case of subclasses in test files (or typos), the actual files containing the deprecations are hard to find.

The Change

This allows the user to configure the file path/name format for their setup. It would allow folks to use the full file paths if that's easier for them and customize in any way that suits while maintaining the current behaviour as the default.

ChrisBr commented 9 months ago

The other consideration would be to go the full distance but place it behind a configuration option to allow for an easier transition.

As discussed in person, I would be in favour of this so we can leave the old behaviour (or at least make it possible to restore the old behaviour).