Shopify / discount-app-components

A library of discounts-focused React components to help in building Shopify apps.
https://www.npmjs.com/package/@shopify/discount-app-components
MIT License
73 stars 25 forks source link

fix: update spacing in MethodCard component #175

Open bolariin opened 11 months ago

bolariin commented 11 months ago

What problem is this PR solving?

I noticed an inconsistency with the spacing between the discount type title and the discount class label for the MethodCard component in the native shopify discount

I noticed a difference with spacing between the discount type title and discount class label for the MethodCard component in the native shopify discount MethodCard component and MethodCard component from this package. This pr resolves the inconsistency by updating the spacing to match the native shopify discount MethodCard.

native shopify discount MethodCard

Screenshot 2023-11-13 at 1 06 18 AM

discount app components MethodCard

Screenshot 2023-11-13 at 12 59 54 AM

discount app components MethodCard after change

Screenshot 2023-11-13 at 12 35 22 AM

Reviewers’ hat-rack :tophat:

Before requesting reviews

Before you deploy

Warning With every PR, you MUST think through each of the items in the following checklist and check the appropriate ones. This step cannot be overlooked by the PR author or its reviewers. Please remove this warning when you're done.

bolariin commented 11 months ago

I've signed the CLA