Shopify / discount-app-components

A library of discounts-focused React components to help in building Shopify apps.
https://www.npmjs.com/package/@shopify/discount-app-components
MIT License
72 stars 23 forks source link

fix: revert to non-shopify job for cla workflow #181

Closed mathiusj closed 10 months ago

mathiusj commented 10 months ago

What problem is this PR solving?

the CLA workflow was failing to lookup IP addresses initially, and it seemed like the right approach was to use shopify-ubuntu-latest based on some threads in slack. This appears to have made it worse (the runner is not found at all for the workflow), which I am now seeing in a discourse thread we should not be using this workflow runner in public repos >.<

https://discourse.shopify.io/t/ip-address-restriction-error-for-cla-workflow-with-public-github-repos/40836/6

original commit: https://github.com/Shopify/discount-app-components/pull/177/commits/0dd2f5a3e33c2ca9755f234ed42eed82f259758a

image

Reviewers’ hat-rack :tophat:

Before requesting reviews

Before you deploy

Warning With every PR, you MUST think through each of the items in the following checklist and check the appropriate ones. This step cannot be overlooked by the PR author or its reviewers. Please remove this warning when you're done.