Shopify / draggable

The JavaScript Drag & Drop library your grandparents warned you about.

https://shopify.github.io/draggable

MIT License

18k stars 1.09k forks source link

fix(plugin:mirror): incorrect use of the function 'positionMirror' #508

Open 0-Captain opened 3 years ago

0-Captain commented 3 years ago

fix #506

Thank you for submitting a pull request! Please make sure you have read the contribution guidelines before proceeding.

This PR implements or fixes... (explain your changes)

incorrect use of the function 'positionMirror' …

This PR closes the following issues... (if applicable)

506

…

Does this PR require the Docs to be updated?

no …

Does this PR require new tests?

no …

This branch been tested on... (click all that apply / add new items)

Browsers:

[x] Chrome 93.0
[] Firefox version
[] Safari version
[ ] IE / Edge version
[ ] iOS Browser version
[ ] Android Browser version

0-Captain commented 3 years ago

After fix this bug, the unit test can't success. I do not know why.

zjffun commented 3 years ago

I fixed the test. Thank you.