[WIP] Bump packages, port to Typescript and Vite usage - Githubissues

Shopify / draggable

The JavaScript Drag & Drop library your grandparents warned you about.

https://shopify.github.io/draggable

MIT License

18k stars 1.09k forks source link

[WIP] Bump packages, port to Typescript and Vite usage #529

Closed hnrq closed 2 years ago

hnrq commented 2 years ago

Thank you for submitting a pull request! Please make sure you have read the contribution guidelines before proceeding.

This PR implements or fixes...

Strong typing;
Replace webpack bundling with Vite. Generates now .es and .umd file, along with a rolled-up .d.ts;
AbstractEvent now extends Event;
Use DOM Testing Library;
Move useFakeTimers to jest.config.js;
Start moving away from test-utils/helpers in favor of Testing Library for standardizing.

TODO:

Fix Example build

Pending questions:

Should we use cancelable and type from Event itself instead of overriding it on AbstractEvent?

Does this PR require the Docs to be updated?

Yes

Does this PR require new tests?

No

This branch been tested on... (click all that apply / add new items)

Browsers:

[x] Chrome version
[x] Firefox version
[ ] Safari version
[ ] IE / Edge version
[ ] iOS Browser version
[ ] Android Browser version