search

Shopify / draggable

The JavaScript Drag & Drop library your grandparents warned you about.
https://shopify.github.io/draggable
MIT License
17.93k stars 1.09k forks source link

Does it make sense to replace AbstractEvent with CustomEvent? #536

Open hnrq opened 2 years ago

hnrq commented 2 years ago

I'm playing around with this lib and I wanted to make a version of my own using modern techs (Vite, testing-library and others). I've seen it has an AbstractEvent class where all Events extend from. Could this class be replaced by the CustomEvent class?

zjffun commented 2 years ago

I think it can be replaced by CustomEvent. We need to check compatibility and use CustomEvent here.

hnrq commented 2 years ago

Looking into CustomEvent at caniuse, looks like it has support for all major browsers except IE, but, like it was mentioned before here, maybe it's time to move on from IE11. I'll submit a PR in a near future for that