Shopify / ejson

EJSON is a small library to manage encrypted secrets using asymmetric encryption.
MIT License
1.34k stars 62 forks source link

Refactor + Intefaces #30

Closed lxfontes closed 7 years ago

lxfontes commented 7 years ago

Why ?

r @burke

This diff sucks :(

burke commented 7 years ago

I'd have preferred for this to be two different PRs, even if they're not shippable individually (commits 1,2,4, vs. commit 3), but anyway:

1,2,4

Is there a rough consensus on using glide now? I've still been using Godep with the 1.7 vendor structure; if you remove Godeps/_workspace, it will just vendor them in the new way when you godep save ./....

If there are lots of other projects using glide, I'm tentatively okay with this, but otherwise I'd prefer to stick to Godep.

You'll also want to bump the version in dev.yml.

3

Looks good at a first glance; I'll go through and review that commit.

burke commented 7 years ago

Yep the actual changes LGTM

lxfontes commented 7 years ago

🤘 splitting this up into 2