Closed lxfontes closed 7 years ago
I'd have preferred for this to be two different PRs, even if they're not shippable individually (commits 1,2,4, vs. commit 3), but anyway:
Is there a rough consensus on using glide now? I've still been using Godep with the 1.7 vendor structure; if you remove Godeps/_workspace, it will just vendor them in the new way when you godep save ./...
.
If there are lots of other projects using glide, I'm tentatively okay with this, but otherwise I'd prefer to stick to Godep.
You'll also want to bump the version in dev.yml
.
Looks good at a first glance; I'll go through and review that commit.
Yep the actual changes LGTM
🤘 splitting this up into 2
Encrypt
, receiving anio.Reader
and outputting toio.Writer
EncryptFileInPlace
Decrypt
, also receivingio.Reader
and outputting toio.Writer
DecryptFile
readFile
,fileMode
godep
toglide
Why ?
r @burke
This diff sucks :(