search

Shopify / ejson

EJSON is a small library to manage encrypted secrets using asymmetric encryption.
MIT License
1.34k stars 62 forks source link

Glide #32

Closed lxfontes closed 7 years ago

lxfontes commented 7 years ago

This is #30 split up into 2 PRs.

Glide adoption is ramping up, Ex: https://github.com/kubernetes/kubernetes/pull/24202

r @andremedeiros

andremedeiros commented 7 years ago

This looks good to me. I like how Glide approaches dependency management much like bundler does.

@burke how do you feel?

burke commented 7 years ago

ok, as long as it's a trend and not just a preference, :shipit:

burke commented 7 years ago

Oh, we're not vendoring deps though? I'm not totally sure how I feel about that, but I guess if we have the ability to specify by ref it's... okay? I did enjoy the fully-reproducible build idea.

lxfontes commented 7 years ago

same feeling here. docs mention it is not necessary (specially if we have rev locks) https://github.com/Masterminds/glide#q-should-i-check-vendor-into-version-control I'm fine not having vendor in there (actually like it), but no problem adding it if you guys think it is necessary.