search

Shopify / ejson

EJSON is a small library to manage encrypted secrets using asymmetric encryption.
MIT License
1.34k stars 62 forks source link

ejson prints non-errors to stderr #55

Closed patrobinson closed 6 years ago

patrobinson commented 6 years ago

In https://github.com/Shopify/ejson/commit/a385d6d5f9c642d29de684b8faa8568a9d8d3720 a change was made to print errors to stderr. It also changed the output for encrypt and keygen to also go to stderr. Since these are not errors they should probably go to stdout

lavoiesl commented 6 years ago

I agree for keygen, but the output of encrypt isn't data, it's more a log, so I’m not sure it belongs in stdout. Is this affecting your workflow?

patrobinson commented 6 years ago

@lavoiesl it broke our library but I just changed it to read stderr. Just thought this might've been unintentional so thought I'd raise it.