search

Shopify / ejson

EJSON is a small library to manage encrypted secrets using asymmetric encryption.
MIT License
1.33k stars 63 forks source link

Add support for Darwin arm64 (M1) build #82

Closed juusom closed 3 years ago

juusom commented 3 years ago

Should fix https://github.com/Shopify/ejson/issues/79 . This seems to work fine on my M1 MacBook.

Edit: I need to get legal approval for the CLA, will try to get it sorted out ASAP.

juusom commented 3 years ago

Does someone need to retrigger the CLA check after signing?

bobthebuilderberlin commented 3 years ago

Eagerly waiting for this to be merged...

bobthebuilderberlin commented 3 years ago

@burke You seem to be the main contributor. Anything you can do on your side to retrigger the CLA check?

burke commented 3 years ago

Thanks—Sorry for the delay!

seanstory commented 3 years ago

This seems to work fine on my M1 MacBook.

Forgive me if this is obvious, but how can I build this on my M1 MacBook? I'd love to get this back working without needing to wait for a release. Cloning and running make is failing with an unhelpful error:

$ make
go mod download
go mod tidy
mkdir -p "build/man/man1"
set -euo pipefail ; bundle exec ronn -r --pipe "man/man1/ejson.1.ronn" | gzip > "build/man/man1/ejson.1.gz" || (rm -f "man/man1/ejson.1.ronn" ; false)
make: *** [build/man/man1/ejson.1.gz] Error 1
juusom commented 3 years ago

I think I had something similar happen but I don't remember what went wrong. Is your git working tree clean? Also, plain make also tries to build the debs which is probably not what you want on OS X. bundle install followed by make setup gem or make setup binaries should do it?

escakot commented 3 years ago

Would there be a new version released soon? So it can be installed via bundler?

Vugario commented 3 years ago

Thanks for the fix! We're eagerly waiting for a new release to be pushed so we can start using ejson on our M1 machines again.

fisherking commented 3 years ago

@burke sorry for disturbing, but are you going to bump the new version and publish it to rubygems.org at some point of time?

burke commented 3 years ago

Done, sorry for the delay: https://github.com/Shopify/ejson/releases/tag/v1.3.0