Shopify / ejson

EJSON is a small library to manage encrypted secrets using asymmetric encryption.
MIT License
1.33k stars 63 forks source link

Add support for arm64 #86

Closed pepicrft closed 3 years ago

pepicrft commented 3 years ago

I tried to run ejson in a M1 laptop, and it throws a segmentation fault issue because the vendored binary is not compatible for arm64. This PR extends the scripts that build the binaries to include a binary for arm64, and adjusts the Gem's executable, to use the arm64 binary when running ejson in a Darwin M1 host.

juusom commented 3 years ago

Well, not that I'd mind whose PR gets merged in the end (it's been right there for a good 17 days - https://github.com/Shopify/ejson/pull/82 ), but should the manifest bit be copied here as well?

Edit: sorry, that might have sounded mildly passive aggressive - didn't mean that, probably something went wrong with the CLA signing on my PR and that's why it got stuck. I really don't mind whose PR gets merged :)

burke commented 3 years ago

I merged the other one