search

Shopify / erb-lint

Lint your ERB or HTML files
MIT License
593 stars 114 forks source link

Fix '**/vendor/**/*' glob broken in dc7cc25 #257

Closed hmcguire-shopify closed 2 years ago

hmcguire-shopify commented 2 years ago

Fix '**/vendor/**/*' glob broken in dc7cc2553dd33df2466a5a31c6cd91d9e1ed7b60

This is similar to the strategy rubocop uses here https://github.com/rubocop/rubocop/blob/d19f902705cb5772f0bc81d87ac652c84bb4c99a/lib/rubocop/config.rb#L163 where they check against absolute and relative paths

I created an example repo to show that both absolute and relative globs work: https://github.com/hmcguire-shopify/erblint-0-1-2-exclude

cc @rafaelfranca

Fixes #258

rafaelfranca commented 2 years ago

Thanks!

nevans commented 2 years ago

Thanks!