Added JUnit.xml support via --format junit - Githubissues

Shopify / erb-lint

Lint your ERB or HTML files

MIT License

592 stars 113 forks source link

Added JUnit.xml support via --format junit #320

Closed mikoto2000 closed 1 year ago

mikoto2000 commented 1 year ago

See: #296 and #295

I take over #296 pull request.

I fork wscourge:main and those fix.

delete unused require
- review comment: https://github.com/Shopify/erb-lint/pull/296#discussion_r1061313035
- commit: 5c0e0d0
fix fixture file and test code
- review comment: https://github.com/Shopify/erb-lint/pull/296#discussion_r1061313612
- commit: 3a17259
modify to use REXML
- review comment: https://github.com/Shopify/erb-lint/pull/296#pullrequestreview-1235622076
- commit: 2c32f10
add line attribute
- review comment: https://github.com/Shopify/erb-lint/pull/296#issuecomment-1370768017
- commit: c1548f2

mikoto2000 commented 1 year ago

I have signed the CLA!

mikoto2000 commented 1 year ago

@wscourge Could you please access the link below and sign the CLA?

https://cla.shopify.com/

See: https://github.com/Shopify/erb-lint/actions/runs/5038095383/jobs/9035358370?pr=320#step:2:12

wscourge commented 1 year ago

I don't think so, no

mikoto2000 commented 1 year ago

@wscourge Thank you for making sure. I understood. I will try to make it from scratch.