Shopify / erb-lint

Lint your ERB or HTML files
MIT License
592 stars 113 forks source link

Centralize Ruby Version to `.ruby-version` #345

Closed george-ma closed 3 months ago

george-ma commented 3 months ago

What are you trying to accomplish?

The .ruby-version file is the ecosystem standard for defining a Ruby version. This PR adds the .ruby-version file, ensures a required_ruby_version is set, and removes all other references to Ruby in this repository, aligning it with the standard.

What should reviewers focus on?

[!IMPORTANT] Please verify the following before merging:

Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:

This PR will be merged if there isn't any activity after 4 weeks.

jenshenny commented 3 months ago

I think we can also remove the ruby version here https://github.com/Shopify/erb-lint/blob/main/.github/workflows/linting.yml#L12 since GA will read from .ruby-version