search

Shopify / erb_lint

Lint your ERB or HTML files
MIT License
676 stars 122 forks source link

Switch from deprecated Cop.all API to Rubocop v1 Registry.all #358

Closed ryanfb closed 3 months ago

ryanfb commented 4 months ago

API change is noted in the V1 upgrade notes here, so there's also a >= 1 requirement on the rubocop gem: https://docs.rubocop.org/rubocop/v1_upgrade_notes.html

Without this, erb-lint winds up emitting a ton of deprecation warnings when used with rubocop >= 1.65.0, which introduces warning messages for deprecated APIs: https://github.com/rubocop/rubocop/pull/13032

ryanfb commented 4 months ago

I have signed the CLA!

honzasterba commented 4 months ago

the warnings with latest Rubocop are annoying, would be great to have this released, let me know if I can help in any way.

etiennebarrie commented 3 months ago

You didn't allow maintainers to edit the pull request so I pushed the changes on main in 0d3944245d816d11dcfee0c010486a62e1872bc2 directly. Thanks!

huda-kh commented 3 months ago

When will this be released to rubygems?

etiennebarrie commented 3 months ago

https://rubygems.org/gems/erb_lint/versions/0.6.0 https://github.com/Shopify/erb_lint/releases/tag/v0.6.0