Open fortmarek opened 2 years ago
This is great. I think we need one from ScrollView as well. We might be missing some things there too. I'd expect that list to be much shorter.
I think we need one from ScrollView as well. We might be missing some things there too.
The ScrollView
props should just work (although we should double-check the whole list).
Afaict, we are only missing one ScrollView
method which is scrollTo
There are some around sticky headers which won't work. We can just filter them out for now. Some can be easily implemented in the future so it would be nice to track them.
FlatList
inherits all the props fromVirtualizedList
. There are some we already support, but not all of them. To achieve complete feature parity withFlatList
, we will need to implement the remainder (except those which don't make sense for our implementation)Props:
CellRendererComponent
https://github.com/Shopify/flash-list/pull/362ItemSeparatorComponent
ListEmptyComponent
ListItemComponent
ListFooterComponent
ListFooterComponentStyle
ListHeaderComponent
ListHeaderComponentStyle
debug
- only for debugging, not necessary to implement as of nowdisableVirtualization
-> this does not make sense for our case. But we can add a propdisableRecycling
. Both props can be used for debugging (not for production as they degrade performance). I'd be against keeping the same name as in our case, virtualization is not technically correct. But inVirtualizedList
, this prop is deprecated, so I think we don't have to implement it for now at least.extraData
getItemLayout
https://github.com/Shopify/flash-list/issues/30horizontal
initialNumToRender
- this is currently covered byestimatedItemSize
initialScrollIndex
inverted
listKey
Does not make sense for our use-casekeyExtractor
maxToRenderPerBatch
- I believe this does not make sense for our implementationonEndReached
we don't supportdistanceFromEnd
onEndReachedThreshold
onRefresh
onScrollToIndexFailed
onViewableItemsChanged
persistentScrollbar
- covered byScrollView
progressViewOffset
refreshControl
refreshing
removeClippedSubviews
- covered byScrollView
renderScrollComponent
viewabilityConfig
viewabilityConfigCallbackPairs
updateCellsBatchingPeriod
- probably also does not make sense for our listwindowSize
- we can either use this (with a different default) or let users specifyrenderAhead
offsetMethods:
flashScrollIndicators
https://github.com/Shopify/flash-list/pull/381getChildContext
- I don't thinks this is something worth investing our time into right now. The object returned from this method would be quite different fromFlatList
anyway.getScrollableNode
getScrollRef
https://github.com/Shopify/flash-list/pull/381getScrollResponder
https://github.com/Shopify/flash-list/pull/381hasMore
scrollToEnd
scrollToIndex
scrollToItem
scrollToOffset
recordInteraction
setNativeProps
https://github.com/Shopify/flash-list/pull/381