search

Shopify / function-examples

MIT License
186 stars 53 forks source link

fix: update dep version of sample-apps #517

Closed FriedRiceNoodles closed 3 months ago

FriedRiceNoodles commented 4 months ago

Trying to build an app with https://shopify.dev/docs/apps/build/discounts/experience#sample-code, then I met this: https://github.com/Shopify/discount-app-components/issues/196

FriedRiceNoodles commented 4 months ago

I have signed the CLA!

FriedRiceNoodles commented 4 months ago

BTW, there is a cartLine target discount using in the tutorials (section 7 of step1), but it wasn't until five days ago that version 2024-07 offered this feature. It means if I don't change my api-version to 2024-07 manually, I'd run into a frustrating error.

https://github.com/Shopify/function-examples/discussions/199#discussioncomment-9693318 https://shopify.dev/docs/api/functions/reference/product-discounts/graphql/common-objects/target?api%5Bversion%5D=2024-07

Shouldn't you label this in the tutorial?

mathiusj commented 3 months ago

BTW, there is a cartLine target discount using in the tutorials (section 7 of step1), but it wasn't until five days ago that version 2024-07 offered this feature. It means if I don't change my api-version to 2024-07 manually, I'd run into a frustrating error.

#199 (comment) https://shopify.dev/docs/api/functions/reference/product-discounts/graphql/common-objects/target?api%5Bversion%5D=2024-07

Shouldn't you label this in the tutorial?

hi @FriedRiceNoodles 👋 thank you for putting this PR up, and sorry for the delay. I don't get notified about this repo unfortunately, which will change now! We are refreshing our developer docs right now and be sure to address this.