Shopify / function-examples

MIT License
182 stars 52 forks source link

fix: downgrade eslint for discounts app #549

Closed mathiusj closed 1 month ago

mathiusj commented 1 month ago

Description

My previous fix worked for yarn packages, but was failing still with npm on:

Error coming from `npm install`

Command failed with exit code 1: npm install
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: specialized-shareholder-app@undefined
npm error Found: eslint@9.7.0
npm error node_modules/eslint
npm error   dev eslint@"^9.0.0" from the root project
...

Seems that the @remix-run/remix package is using eslint@^8.23.1 which is causing the dependency conflict:

https://github.com/remix-run/remix/blob/main/package.json#L99

🎩 Instructions

shopify app init --template https://github.com/Shopify/function-examples/sample-apps/discounts\#mathiusj/downgrade-eslint-discounts should not fail 🙏 try shopify app init --template https://github.com/Shopify/function-examples/sample-apps/discounts --package-manager yarn and you will see that it does