ControlServer ETA is negative after "Done"

Shopify / ghostferry

The swiss army knife of live data migrations

https://shopify.github.io/ghostferry

MIT License

748 stars 70 forks source link

ControlServer ETA is negative after "Done" #251

Closed shuhaowu closed 3 years ago

shuhaowu commented 3 years ago

It seems like the ETA in the ControlServer UI continues to calculate after the Done state, which results in a negative ETA value. This should be fixed.

lstp commented 3 years ago

@shuhaowu I wasn't able to replicate this locally. Do you mind adding steps to replicate the issue. I see ETA as 0 when I run a test locally.

Screen Shot 2021-02-09 at 1 23 55 PM

tiwilliam commented 3 years ago

This could be due to targetPaginationKeys being empty or almost empty if resuming a run. That would cause totalPaginationKeysToCopy to be smaller than completedPaginationKeys and generate a negative number.

lstp commented 3 years ago

resolved in https://github.com/Shopify/ghostferry/pull/256