search

Shopify / ghostferry

The swiss army knife of live data migrations
https://shopify.github.io/ghostferry
MIT License
694 stars 65 forks source link

Binlog writer lag and target binlog streamer lag #274

Closed shuhaowu closed 3 years ago

shuhaowu commented 3 years ago

The binlog writer and binlog streamer lag can diverge. This allows us to track them individually in the Progress struct.

Furthermore, the target binlog streamer lag is a thing when the TargetVerifier is active, this allows us to track that lag when it is in use.

Also ran go fmt in a few places. We should probably setup CI to catch format issues.

xliang6 commented 3 years ago

This looks good overall. 👍

shuhaowu commented 3 years ago

I tested this and it works. would appreciate a review