In commit f88c58523988b9fc98f14c6a69c138279f257fe6, we stop initializing ferry.ErrorHandler in sharding and copydb and make Ferry.Initialize do it. This triggers a problem where an error can occur before the ErrorHandler is initialized, which results in a nil-pointer exception as sharding uses ferry.ErrorHandler to report this error.
This is fixed here in a non-ideal way, as it's unclear how the ErrorHandler should be initialized. The original intention is that the
ErrorHandler should be initialzed only by the application and then passed into Ferry. That said, Ferry still needs a default value for ErrorHandler in case it is not passed in, which would require Ferry to initialize it. Additionally, the Initialize code is structured such that it first performs the sanity check and then initialize all components (incl. the ErrorHandler). So this fix breaks up the code a bit. I'm not sure what the ideal solution is, but this is probably ok for now.
Another thing I changed is to reduce the dependency of the PanicErrorHandler on Ferry. Ideally we can completely get rid of the dependency to make the PanicErrorHandler a component independent of the Ferry, but there's no good way to do that now.
In commit f88c58523988b9fc98f14c6a69c138279f257fe6, we stop initializing
ferry.ErrorHandlerin sharding and copydb and makeFerry.Initializedo it. This triggers a problem where an error can occur before theErrorHandleris initialized, which results in a nil-pointer exception as sharding usesferry.ErrorHandlerto report this error.This is fixed here in a non-ideal way, as it's unclear how the
ErrorHandlershould be initialized. The original intention is that theErrorHandlershould be initialzed only by the application and then passed into Ferry. That said, Ferry still needs a default value forErrorHandlerin case it is not passed in, which would require Ferry to initialize it. Additionally, theInitializecode is structured such that it first performs the sanity check and then initialize all components (incl. theErrorHandler). So this fix breaks up the code a bit. I'm not sure what the ideal solution is, but this is probably ok for now.Another thing I changed is to reduce the dependency of the PanicErrorHandler on Ferry. Ideally we can completely get rid of the dependency to make the PanicErrorHandler a component independent of the Ferry, but there's no good way to do that now.