search

Shopify / ghostferry

The swiss army knife of live data migrations
https://shopify.github.io/ghostferry
MIT License
694 stars 65 forks source link

refactor ErrorHandler in ferry #284

Open Manan007224 opened 3 years ago

Manan007224 commented 3 years ago

Currently copydb and sharding are also calling ErrorHandler on ferry to repor the error to the ErrorCallback object whenever any errors occur before the ferry starts running, and after that ferry internally calls the ErrorHandler when any of the components in ferry (DataWriter, BinlogStreamer etc) fails. This is not a desirable design as we should not be calling the ErrorHandler from copydb and sharding. This might require some refactoring on how ErrorHandler works and which component owns this object (copydb. sharding or ferry itself).

varks commented 11 months ago

@Manan007224 would like to help on this. Is this still needed?